Allow passthrough of xgettext's plural templates#1185
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1185 +/- ##
=======================================
Coverage 91.68% 91.68%
=======================================
Files 27 27
Lines 4689 4690 +1
=======================================
+ Hits 4299 4300 +1
Misses 390 390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I wonder if it'd be better to either reject these (with a nicer error message) or try to detect the This way the catalog wouldn't be in this weird partially valid state. For type-checked code you also wouldn't need to type guard |
As #1154 reported, Babel would choke trying to parse a plural expression that is but a template.
After this, such templates can be parsed and manipulated, but may have strange interactions with other features.