Changed get_week_number() to fix a problem with the locale en_AU#1146
Open
RomainBarbason wants to merge 3 commits intopython-babel:masterfrom
Open
Changed get_week_number() to fix a problem with the locale en_AU#1146RomainBarbason wants to merge 3 commits intopython-babel:masterfrom
RomainBarbason wants to merge 3 commits intopython-babel:masterfrom
Conversation
Member
|
Thanks for the PR! Do you think you could add some tests for this fix? Somewhere here might be a good place: Lines 715 to 720 in 313277a |
Member
|
Yep, as Tomas said, a test would be very much appreciated - the week numbering logic seems to be pretty finicky all in all... |
Author
|
Hi ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first pull-request ever, so don't hesitate to give me feedback on anything
If my analysis is correct, get_week_number() made it impossible for iso-calendar to show their last week, because the week_number was fixed from 53 to 1, while it should be fixed to 52.
That's why the year wasn't updated and the result was "W1 2023", it should be "W52 2023".
Hope this helps !
Fixes #1133