Conversation
Add solution plots to poisson solver notebook
campospinto
left a comment
campospinto
left a comment
There was a problem hiding this comment.
Very nice, thanks! From the webpage build in the CI Artifacts the results look good to me.
(I guess there is a way to avoid the cell id's to be changed, but this is not a big problem)
|
For completeness you can add a short description of your PR (by editing the first cell in this conversation). |
yguclu
left a comment
yguclu
left a comment
There was a problem hiding this comment.
@anushkasinghh Thanks for this PR. I have a couple of comments.
| "# Define the exact solution as a symbolic expression (example: phi_exact = x^2 + y^2)\n", | ||
| "ue = sin(np.pi*x)*sin(np.pi*y)\n", | ||
| "\n", |
There was a problem hiding this comment.
ue was already defined in the section titled "Computing the L^2 norm", as it was needed to define the error norms. Please remove its definition from this place, and move the comment line (which is useful) to the previous definition.
There was a problem hiding this comment.
By the way, I have just realized that the same section redefines u, which was previously defined in the section titled "Formal Model". Could you please remove the second definition?
| "cell_type": "code", | ||
| "execution_count": null, | ||
| "id": "d829e410", | ||
| "id": "827c3e69-77ac-4312-a4dd-a1c26a40b27c", |
There was a problem hiding this comment.
I think that this id can be changed by hand to its original value using a text editor (or from the GitHub web interface). If it causes a problem, our CI build will spot it.
3 participants
added plotting function for numerical & analytics solutions and the error