docs: change update translation sessions in nox#398
Conversation
|
minor thing: i wonder if we can pick one term to refer to a translation or language? currently we have something like this
i don't have a strong preference between four sessions vs two sessions s.t. with no arguments they build/update all languages but with an argument only update a single language (or only the released langs, etc), but i think in either case it would be good to pick either language or translation to refer to them |
Good point, that makes sense, maybe "languages" is more semantically correct? |
|
I did a bit of reorganization of the nox sessions related to translations, to harmonize the names. I also simplified it a bit, to remove the internal build to release variable. Here is the proposed setup:
|
sneakers-the-rat
left a comment
There was a problem hiding this comment.
I like it - good with me :)
as an aside, since i'm not asking you to fix nox in this PR - the only thing i wish is that nox had a bit of a better way of sharing venvs, because each of these will make their own venv which makes things big and slow. making each of the sessions independent (rather than using notify) i think makes them tidier and easier to read than notify and posargs, which i like tho, so it's an improvement imo :)
|
Thanks @flpm ! |
|
Wondering if we can merge this? i gave approval but i guess i don't have the right permissions or role or w/e to overcome the merge block. |
|
oh @sneakers-the-rat i'm just getting caught up on things. you should have permissions to merge. let me check right now. |
|
Jonny, I just added you to the packaging council team. Can you please try to use your superpowers to merge? You should be able to. Y'all - anytime something is being blocked because someone doesn't have enough permissions, please feel free to tag me directly !! i don't want to hold this work up. |
|
anyone on this thread should now be able to merge!! |
|
I just realized that this change of nox session names should be reflected in the contributor translation guide. I will make that change and then we can merge! |
|
@flpm how about you merge once you've made the changes you want :) |
sneakers-the-rat
left a comment
There was a problem hiding this comment.
i'm just gonna keep approving this lol i like what you're up to

What was done
Following the discussion in PR #397, this PR makes the following changes:
update-translationssession to only update translation files for languages inRELEASE_LANGUAGES.update-langugagethat can be used to update the translation files for a specific language.This PR also fixes a small syntax issue in the
documentation.pofile for the Spanish translation (missing quote).How to test
Run
nox -s update-translationsand confirm in the output that no languages are updatedRun
nox -s update-language -- esand verify that the .po files for the Spanish translation are updated