do not use an instantiated Instapush() as the exports value#1
Open
mrose17 wants to merge 2 commits intopushbots:masterfrom
Open
do not use an instantiated Instapush() as the exports value#1mrose17 wants to merge 2 commits intopushbots:masterfrom
mrose17 wants to merge 2 commits intopushbots:masterfrom
Conversation
otherwise when require'd, the caller can not make more than one Instapush object
Author
|
ping! |
|
+1 this breaks for multi-user setups. The require subsystem caches the 'new Instapush()' singleton. Until this change is merged/managed, have to hijack the prototype for a new instance, messy and can't anticipate any release changes : |
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otherwise when require'd, the caller can not make more than one Instapush object...