Update to fix defines that collide with other commonly used defines.#10
Open
suicvne wants to merge 1 commit intopsxdev:masterfrom
Open
Update to fix defines that collide with other commonly used defines.#10suicvne wants to merge 1 commit intopsxdev:masterfrom
suicvne wants to merge 1 commit intopsxdev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently I experienced the
#define's for log levels very badly conflicted with a library I was trying to port. Essentially, by defining them as such, it broke macros that had the wordsDEBUGorERRORorINFOon them.The fix is to re-define the log levels with the library as a prefix.
becomes
This is important, the errors that are generated by these macros conflicting are vague and non-descript. Not to mention this library is bundled with VITASDK!