Add fallback for pkg-config in setup.py#246
Merged
IshaanDesai merged 1 commit intodevelopfrom Oct 15, 2025
Merged
Conversation
1f1ce08 to
0d77833
Compare
IshaanDesai
reviewed
Oct 14, 2025
Member
IshaanDesai
left a comment
There was a problem hiding this comment.
This allows to always build a source distribution of the bindings, which is important for a smooth release process.
Does this essentially mean that now we allow pyprecice to be built on a system where preCICE is potentially not installed or not findable?
Member
Author
|
Installing pyprecice without preCICE installed will always fail when building the wheel. The only thing that now works on a system without preCICE is to "build" or assemble the source distribution. So the error is now triggered one step further down the line, when compiling instead of the configuration stage of the extensions. |
IshaanDesai
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a fallback to the setup.py in case preCICE is not found via pkg-config.
The fallback uses no cflags (aka. expect system install) and the
-lpreciceldflag.This allows to always build a source distribution of the bindings, which is important for a smooth release process.
A missing preCICE installation will result in a failed wheel build with: