Update @emotion/* dependencies#151
Open
MatiasCiccone wants to merge 3 commits intopraneshr:masterfrom
Open
Conversation
HaleyWardo
reviewed
Aug 15, 2022
|
@praneshr is there anyway we can get this change in? I am also running into this issue with the new MUI V5 update and this is blocking me from moving forward with releasing. Unfortunately, A simple resolution won't work because of the package rename. 🙏 |
Co-authored-by: Haley <haley.ward@lifeomic.com>
HaleyWardo
reviewed
Aug 15, 2022
HaleyWardo
left a comment
HaleyWardo
left a comment
There was a problem hiding this comment.
Thank you for making that update! Also, It looks like there are merge conflicts.
|
You might wanna create that PR against https://github.com/Aeolun/react-diff-viewer-continued |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our project, we had a compatibility issue with the current emotion versions installed in the project and other dependencies after upgrading to MUI 5 and React 17.
I would like to keep emotion updated for this library, do you agree?
Meanwhile, we are working with a fork published on NPM with the new dependencies
PD. I also noticed that classnames could be removed from the project and use the emotion built-in utility for classes