fix: fpw when split non-root page#169
Open
buriedpot wants to merge 1 commit intopostgrespro:masterfrom
Open
Conversation
When we split non-root page, if FPW is not performed, PANIC or WARNING will occur on standby nodes. We fix this bug in this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we split non-root page, if FPW is not performed, PANIC or WARNING will occur on standby nodes. This commit fix this bug.
We can reproduce this bug with PG 18 (the newest released PG version) and RUM master branch.
Then the standby server will PANIC and crash.

Although full_page_writes is turned on by default, the new page should still be registered with
GENERIC_XLOG_FULL_IMAGEflag, which is a standard behaviour.Thank you for reviewing.