Add reverse sorting on commitfest page#33
Merged
JelteF merged 4 commits intopostgres:mainfrom Feb 16, 2025
destrex271:feature/reverse_sorting_v3
Merged
Add reverse sorting on commitfest page#33JelteF merged 4 commits intopostgres:mainfrom destrex271:feature/reverse_sorting_v3
JelteF merged 4 commits intopostgres:mainfrom
destrex271:feature/reverse_sorting_v3
Conversation
Contributor
Author
|
@JelteF I think this should do it |
JelteF
reviewed
Feb 16, 2025
media/commitfest/js/commitfest.js
Outdated
| } | ||
| $("#filterform").submit(); | ||
| let sortkey = $('#id_sortkey').val() | ||
| if (sortkey == sortby) { |
Collaborator
There was a problem hiding this comment.
The logic works well, but the html template should be changed here:
pgcommitfest/pgcommitfest/commitfest/templates/commitfest.html
Lines 63 to 74 in 0f23363
It needs to show glyphicon-arrow-up for the reverse sort.
Collaborator
|
I pushed two small changes to this branch and merged it. FYI for next time it was failing the formatting/linting checks. You can run those locally using |
Collaborator
|
Thanks for the contribution. |
JelteF
added a commit
that referenced
this pull request
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements reverse sorting in the columns of the commitfest pages.
This is a cleaned up version of #28 and #32
Fixes #20