Add SSL integration tests #82
Merged
+219
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponylang-main
added
the
discuss during sync
Adds integration tests that exercise SSL connections against real PostgreSQL instances, replacing mock-only coverage for SSL behavior. Locally, `make start-pg-containers` now starts two PostgreSQL containers — one plain on port 5432 and one with SSL on port 5433. The SSL container reuses the existing test certificates from assets/, with an entrypoint wrapper to fix key file permissions. In CI, a pre-built GHCR image (ghcr.io/ponylang/postgres-ci-pg-ssl) provides the SSL-enabled PostgreSQL as a service container, since GitHub Actions service containers start before checkout and can't mount repo files. A build-ci-image.yml workflow rebuilds the image on demand. Four new integration tests: - SSL/Connect: verify successful SSL connection - SSL/Authenticate: verify MD5 auth over SSL - SSL/Query: execute and verify query results over SSL - SSL/Refused: verify SSLRequired fails against non-SSL server Closes #80
SeanTAllen
force-pushed
the
ssl-integration-tests
branch
from
f898bf5 to
406c29a
Compare
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds integration tests that exercise SSL connections against real PostgreSQL instances, replacing mock-only coverage for SSL behavior.
Two Docker containers are now started by
make start-pg-containers: a plain PostgreSQL on port 5432 and an SSL-enabled one on port 5433. The SSL container reuses the existing test certificates fromassets/, with an entrypoint wrapper to fix key file permissions (PostgreSQL requires 0600 on the private key).Four new integration tests:
SSLRequiredfails against non-SSL serverCloses #80