Pass extra include directory needed for jsoncpp on OpenBSD#8
Open
jasperla wants to merge 1 commit intopolybar:masterfrom
jasperla:openbsd/jsoncpp
Open
Pass extra include directory needed for jsoncpp on OpenBSD#8jasperla wants to merge 1 commit intopolybar:masterfrom jasperla:openbsd/jsoncpp
jasperla wants to merge 1 commit intopolybar:masterfrom
jasperla:openbsd/jsoncpp
Conversation
Member
|
Isn't that something that should be provided by pkg-config from the |
Author
|
Turns out that the include directory from the |
patrick96
requested changes
Nov 22, 2019
Member
patrick96
left a comment
patrick96
left a comment
There was a problem hiding this comment.
I think it would be better to directly use the JSONCPP_INCLUDE_DIRS name instead of JSONCPP_INCLUDEDIR. This way we don't have to manually set the JSONCPP_INCLUDEDIR variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.