Open
Conversation
Member
|
Hi @AntoineDao, it seems the new openapi_inheritance.json has some problems. The openapi-generator failed to generate any codes. |
Member
|
This is most likely because we updated to the new version of Pydantic. I'll be happy to test that if I can run the code on my side. |
Member
Author
|
@mostaphaRoudsari these errors were cause by https://github.com/pollination/pollination-server/issues/507. I have resolved it in staging and will push an updated version to this branch now. |
Member
Author
|
@MingboPeng I have managed to reduce the number of errors from the C# build with the updated The few errors left are about:
I imagine these issues would have happened before so it might be worth you looking into it to confirm whether it's just a bug on my end or if we can do something else to fix it 🙌 Error log: |
AntoineDao
requested review from
MingboPeng
and removed request for
MingboPeng
Member
|
Hi @AntoineDao! Great to know. I was NOT looking forward to debugging that code. 😄 |
Member
|
Thanks @AntoineDao, In @mostaphaRoudsari 's scripts, all object will be added to inherent a base class OpenAPIGenBaseModel, not sure why The following three enums are added to the wrong places in mapper.json. They should be added to enums instead of classes
|
Member
|
There are several new classes that have a property named "type" which conflicts with the reserved "type" for indicating object type when deserializing json string to C# object.
|
Member
|
There are two "MetaData" classes that are conflicting. |
Member
|
A class Accessor has a |
Member
|
LicensePublic has a required property |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @MingboPeng, in order to make it easier for you to productively work with the new API while we iron out SDK generation from pollination-server I have added the new OpenAPI generated for v0.22.0 of the API.
I did run into an issue with the last step of the
generate.pyscript which runsdotnet build. Here is a log of the error which you might help me understand 😀re https://github.com/pollination/pollination-server/pull/495 and #135