Open
Conversation
Contributor
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk and @raema)
examples/M/README.txt line 5 at r1 (raw file):
This example is intended for C++ programmers. This is example consists of these files:
drop is here
examples/M/README.txt line 7 at r1 (raw file):
This is example consists of these files: main.cpp -- ecample creating a mult-tier cache using pmem
FYI, misspell - ecample
fix typo
fix typo
Author
|
Thanks @lukaszstolarczuk I fixed these typos |
Contributor
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting this pull request as WIP for adding multi-tier cachelib example
This change is