Skip to content
This repository was archived by the owner on Jul 6, 2021. It is now read-only.

save new helpdesk itemtype for active profile when installing#59

Open
btry wants to merge 3 commits intopluginsGLPI:developfrom
btry:feature/fix_helpdesk_itemtype_after_install
Open

save new helpdesk itemtype for active profile when installing#59
btry wants to merge 3 commits intopluginsGLPI:developfrom
btry:feature/fix_helpdesk_itemtype_after_install

Conversation

@btry
Copy link
Contributor

@btry btry commented Mar 8, 2017

see #55

@btry btry added the bug label Mar 8, 2017
@btry btry self-assigned this Mar 8, 2017
@btry btry requested a review from orthagh March 8, 2017 21:46
Copy link
Contributor

@orthagh orthagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me.
By the way, you're picky when using JSON_OBJECT_AS_ARRAY instead true (like in the official documentation)

@btry
Copy link
Contributor Author

btry commented Mar 9, 2017

About my use of JSON_OBJECT_AS_ARRAY : I consider I did an error. i'm lucky json_decode does not compares the 2nd argument with ===.

I add a commit to fix this

@cedric-anne cedric-anne force-pushed the feature/fix_helpdesk_itemtype_after_install branch from b262f3e to e4ebd4a Compare September 6, 2019 12:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants