Fix - Prevent MySQL table name overflow during GenericObject to CustomAsset migration#1127
Open
Fix - Prevent MySQL table name overflow during GenericObject to CustomAsset migration#1127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Fixes table name overflow error during Fields plugin migration from GenericObject to CustomAssets in GLPI 11.0.
Problem
When migrating Fields containers associated with GenericObject items to native CustomAssets, the generated MySQL table names exceeded the 64-character limit:
glpi_plugin_fields_glpicustomassetliaisonassetliaisonsautresinfos(65 chars)This caused migration failures with error:
Solution
Use abbreviated prefix
gca(GLPI CustomAsset) instead ofglpicustomasset:glpi_plugin_fields_gcaliaisonassetliaisonsautresinfos(53 chars) ✓This approach:
Changes
installBaseData()migration logic to usegcaprefixgetSystemName()to apply abbreviation forGlpi\CustomAsset\*itemtypes