Draft
Conversation
Contributor
Author
|
Can you try this ? Best regards |
Contributor
Author
|
I'd like your opinion on this. Thank you in advance |
Contributor
|
I don't have the plugin installed/configured anymore, but I didn't see anything in the code itself of concern as long as there is no way for the fields plugin to add fields to native custom assets and custom dropdowns. Both add custom fields to a "custom_fields" property and it doesn't seem like this code checks if it already exists to merge the properties instead. Edit: Well maybe not... I haven't fully woken up yet. Are you trying to add the custom fields into the existing asset schemas or create new ones? |
Contributor
Author
|
Yes, now cf : #1112 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Replace #670
Screenshots (if appropriate):