Conversation
Contributor
Author
Rom1-B
force-pushed
the
fix/skip_rules_param
branch
from
6934fbf to
0af40d0
Compare
Herafia
force-pushed
the
fix/skip_rules_param
branch
from
0af40d0 to
fbff91b
Compare
Rom1-B
force-pushed
the
fix/skip_rules_param
branch
from
fbff91b to
322b69a
Compare
…rule execution during ticket escalation
Herafia
force-pushed
the
fix/skip_rules_param
branch
from
322b69a to
212061d
Compare
stonebuzz
reviewed
Feb 4, 2026
tests/Units/TicketTest.php
Outdated
| 'entities_id' => 0, | ||
| 'is_recursive' => 1, | ||
| ]); | ||
| $group_tech_id = $group_tech->getID(); |
Rom1-B
requested changes
Feb 4, 2026
Comment on lines
418
to
431
| // Observer group may or may not be added depending on the escalation path and GLPI internals. | ||
| // If RuleTicket is executed, observer group must be added exactly once | ||
|
|
||
| $observer_count = count($group_ticket->find([ | ||
| 'tickets_id' => $ticket_id, | ||
| 'groups_id' => $group_observer_id, | ||
| 'type' => \CommonITILActor::OBSERVER | ||
| ])); | ||
|
|
||
| $this->assertContains( | ||
| $observer_count, | ||
| [0, 1], | ||
| 'Observer group count must be 0 or 1' | ||
| ); |
Contributor
There was a problem hiding this comment.
It is either always 0 or always 1, but it should not vary in an CI test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Screenshots (if appropriate):