Conversation
|
I can't assign reviewer on this repo @AdrienClairembault |
AdrienClairembault
left a comment
AdrienClairembault
left a comment
There was a problem hiding this comment.
Personally I am not a fan of code coverage as I find it to be a bad metric, but if you find it useful on your side and can gain something from it then I don't mind adding it.
|
It was an idea we discussed with @Rom1-B, but yes coverage could be an indicator for forgotten test on some function but indeed the value shouldn't be taken as proof. I.E: In whatsapp the api calls to the whatsapp API can't be tested and the coverage won't be high. But it can put in light some important method that should be tested. |
| # To enable code coverage reporting, | ||
| # ensure that the project variable "CODE_COVERAGE" is set to "true" | ||
|
|
There was a problem hiding this comment.
Already specified in README file
| ## Enabling Code coverage | ||
| By default, code coverage is disabled. | ||
|
|
||
| If you want to enable it, you have to set your project environment variable `CODE_COVERAGE` to `true`. | ||
|
|
There was a problem hiding this comment.
It's probably not enough, since you require a specific file name, and certainly a specific format.
There was a problem hiding this comment.
I think we should do as in the other CI steps (e.g., PHPstan), which are triggered by the presence of the config file and not a variable.
4 participants
Add coverage configuration support using project env variable.
This will create a coverage report on the PR.
CI won't fail, just display a report.
Interconnected PR :