Fix Python version comparison logic in post-gen hook #174
+1
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The current string comparison
sys.version.split(' ')[0] > '3.2'incorrectly evaluates toFalsefor Python 3.11 (since'1' < '2'), causing the script to look for virtualenv instead of using the built-invenvmodule.Proposed Change:
Use
sys.version_info >= (3, 3)for a correct numerical comparison. This ensures modern Python environments use the nativevenvmodule as intended without requiring additional legacy dependencies.Note:
While installing
virtualenvmanually can bypass the error, usingsys.version_infois more robust to handle version checks in Python.