This repository was archived by the owner on Dec 31, 2025. It is now read-only.
[WIP] Add unit tests for creating secrets#158
Open
ojmhetar wants to merge 2 commits intoprivate/ojas/create-secretsfrom
Open
[WIP] Add unit tests for creating secrets#158ojmhetar wants to merge 2 commits intoprivate/ojas/create-secretsfrom
ojmhetar wants to merge 2 commits intoprivate/ojas/create-secretsfrom
Conversation
ojmhetar
force-pushed
the
private/ojas/create-cluster
branch
from
07470e5 to
64de9a7
Compare
ojmhetar
force-pushed
the
private/ojas/create-secret-test
branch
from
d83a796 to
5c80aea
Compare
ojmhetar
changed the base branch from
private/ojas/create-cluster
to
private/ojas/create-secrets
ojmhetar
force-pushed
the
private/ojas/create-secrets
branch
from
adc9082 to
0c497e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Introduces a few unit tests for secrets.
Notes
Open to all discussion points. I see that
state_test.goexists in the same directory as the file(s) it tests, is this a preferred convention?Which issue(s) this PR fixes:
n/a