use Mapping instead of Dict, Sequence instead of List#306
Open
Thyrst wants to merge 1 commit intopinecone-io:mainfrom
Open
use Mapping instead of Dict, Sequence instead of List#306Thyrst wants to merge 1 commit intopinecone-io:mainfrom
Thyrst wants to merge 1 commit intopinecone-io:mainfrom
Conversation
|
Is there a reason this is in draft? |
453d7cb to
9074caa
Compare
Author
It may not cover all places that need change but is ok to be merged. Marked it as ready. |
Collaborator
|
I appreciate the effort here, but code in the |
Author
I see, thanks for the update. You can let me know once it's ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Describe the purpose of this change. What problem is being solved and why?
Solution
Using Mapping and Sequence where appropriate.
Type of Change
Test Plan
Viz Steps To Reproduce in the linked issue.
To test the fix, change
pinecone-clientversion to this branch and run Pyright again.