Skip to content

feat(python): Relax strict urllib3 version pin #SCD-642 #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jablan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(python): Relax strict urllib3 version pin #SCD-642 #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openapi-generator/templates/python/README_onlypackage.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ This python library package is generated without supporting files like setup.py

To be able to use it, you will need these dependencies in your own package that uses this library:

* urllib3 >= 1.15, < 2.6
* urllib3 >= 1.15, < 3, != 2.6.0
* six >= 1.10
* certifi
* python-dateutil
Expand Down
2 changes: 1 addition & 1 deletion openapi-generator/templates/python/python-experimental/README_onlypackage.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ This python library package is generated without supporting files like setup.py

To be able to use it, you will need these dependencies in your own package that uses this library:

* urllib3 >= 1.15, < 2.6
* urllib3 >= 1.15, < 3, != 2.6.0
* six >= 1.10
* certifi
* python-dateutil
Expand Down
2 changes: 1 addition & 1 deletion openapi-generator/templates/python/python-experimental/requirements.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ future; python_version<="2.7"
six >= 1.10
python_dateutil >= 2.5.3
setuptools >= 21.0.0
urllib3 >= 1.15.1, < 2.6
urllib3 >= 1.15.1, < 3, != 2.6.0
2 changes: 1 addition & 1 deletion openapi-generator/templates/python/python-experimental/setup.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ VERSION = "{{packageVersion}}"
# http://pypi.python.org/pypi/setuptools

REQUIRES = [
"urllib3>=1.15,<2.6",
"urllib3>=1.15,<3,!=2.6.0",
"six >= 1.10",
"certifi",
"python-dateutil",
Expand Down
2 changes: 1 addition & 1 deletion openapi-generator/templates/python/requirements.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ future; python_version<="2.7"
six >= 1.10
python_dateutil >= 2.5.3
setuptools >= 21.0.0
urllib3 >= 1.15.1, < 2.6
urllib3 >= 1.15.1, < 3, != 2.6.0
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version specifier formatting differs between templates (e.g., urllib3>=1.15,<3,!=2.6.0 in setup.mustache vs urllib3 >= 1.15.1, < 3, != 2.6.0 here). While both are valid, keeping consistent spacing/formatting across generated artifacts improves readability and reduces churn in downstream diffs. Consider adopting one canonical style (with or without spaces) across all templates.

Suggested change
urllib3 >= 1.15.1, < 3, != 2.6.0
urllib3>=1.15.1,<3,!=2.6.0

Copilot uses AI. Check for mistakes.
2 changes: 1 addition & 1 deletion openapi-generator/templates/python/setup.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ VERSION = "{{packageVersion}}"
# prerequisite: setuptools
# http://pypi.python.org/pypi/setuptools

REQUIRES = ["urllib3>=1.15,<2.6", "six >= 1.10", "certifi", "python-dateutil"]
REQUIRES = ["urllib3>=1.15,<3,!=2.6.0", "six >= 1.10", "certifi", "python-dateutil"]
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The urllib3 lower bound here (>=1.15) is inconsistent with the requirements.mustache lower bound (>=1.15.1) and the README examples (>=1.15). This makes it harder to reason about the actual supported range and can lead to mismatched installs depending on which artifact a consumer uses. Recommend standardizing the urllib3 specifier (same lower bound + exclusions) across setup/requirements/README templates.

Suggested change
REQUIRES = ["urllib3>=1.15,<3,!=2.6.0", "six >= 1.10", "certifi", "python-dateutil"]
REQUIRES = ["urllib3>=1.15.1,<3,!=2.6.0", "six >= 1.10", "certifi", "python-dateutil"]

Copilot uses AI. Check for mistakes.
{{#asyncio}}
REQUIRES.append("aiohttp >= 3.0.0")
{{/asyncio}}
Expand Down
Loading