-
-
Notifications
You must be signed in to change notification settings - Fork 346
Recognize simple current-class objects for unused private method #1069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kylekatarnls
wants to merge
8
commits into
3.x
Choose a base branch
from
feature/detect-self-type-for-unused-private-method
base: 3.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Recognize simple current-class objects for unused private method #1069
kylekatarnls
wants to merge
8
commits into
3.x
from
feature/detect-self-type-for-unused-private-method
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 3.x #1069 +/- ##
============================================
- Coverage 92.56% 91.85% -0.72%
- Complexity 1252 1300 +48
============================================
Files 111 114 +3
Lines 3429 3534 +105
============================================
+ Hits 3174 3246 +72
- Misses 255 288 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4ce69a6 to
f02541c
Compare
ab8a979 to
6ca471f
Compare
6ca471f to
8354e05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bugfix
Issue: Resolves #252 / Resolves #558 / Resolves #937
Breaking change: no
Recognize simple constructions of the current class for unused private method rule, such as:
new Foo(with Foo matching FQCN of the current class, includingself,static)clone $this(or clone of a variable recognized as of type of the current class)