Indicate anonymous classes allow optional trailing commas in arg list#260
Open
ramsey wants to merge 1 commit intophp:masterfrom
Open
Indicate anonymous classes allow optional trailing commas in arg list#260ramsey wants to merge 1 commit intophp:masterfrom
ramsey wants to merge 1 commit intophp:masterfrom
Conversation
iluuu1994
reviewed
Feb 25, 2024
| 'new' class-type-designator '(' argument-expression-list ','? ')' | ||
| 'new' class-type-designator | ||
| 'new' 'class' '(' argument-expression-list? ')' class-base-clause? class-interface-clause? '{' class-member-declarations? '}' | ||
| 'new' 'class' '(' argument-expression-list ','? ')' class-base-clause? class-interface-clause? '{' class-member-declarations? '}' |
Member
There was a problem hiding this comment.
I believe this should either use ',' without ?, or the existing line should be extended with ','?. Otherwise, the two productions are ambiguous, code without the comma can be parsed by either. I see this is already wildly inconsistent in the grammar, so maybe I'm missing something.
Member
Author
There was a problem hiding this comment.
Maybe? I was trying to follow the patterns I saw elsewhere in the grammar, but I can't find any information on the specification for the grammar we use, so it's difficult to understand what is meant or intended in places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.