Add explicit type declarations to class constants (PHP 8.3+)#215
Merged
Girgias merged 8 commits intophp:masterfrom Feb 5, 2026
Merged
Add explicit type declarations to class constants (PHP 8.3+)#215Girgias merged 8 commits intophp:masterfrom
Girgias merged 8 commits intophp:masterfrom
Conversation
Girgias
requested changes
Feb 4, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Can you update the composer.json file to require 8.3? I checked with Derick and the doc machine runs 8.3 so it should be fine.
When <function> contains <replaceable>, skip link/parentheses processing in format_function_text() and output plain text instead. Uses the role stack pattern already established by format_constant(). Fixes php#171
Girgias
approved these changes
Feb 5, 2026
Member
|
Might need to get rid of the 8.1 and 8.2 CI too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces explicit type declarations for class constants, leveraging the feature introduced in PHP 8.3.
Motivation
Scope
int,string,bool, orarrayto class constants.Before:
public const FORMAT_HTML = 1;
public const NAME = 'PhD';
After:
public const int FORMAT_HTML = 1;
public const string NAME = 'PhD';
Impact
References