Fixed - pdo_odbcのconstruct引数の翻訳の誤りを修正#203
Merged
KentarouTakeda merged 1 commit intophp:masterfrom Dec 2, 2024
Merged
Conversation
Member
Author
|
CI落ちてるのは上流の問題ですので、解消をお待ちください.... |
KentarouTakeda
approved these changes
Dec 2, 2024
Collaborator
KentarouTakeda
left a comment
KentarouTakeda
left a comment
There was a problem hiding this comment.
ありがとうございます！
原文と実装の双方で、修正後の文章が正しいことを確認しました。CIに影響のある修正でないことは明らかなので、こちらでマージします。
Member
@SakiTakamachi の php/doc-en@ddb05f8 を日本語版に sync しないとビルドは通らない。上流の問題ではない。 |
Member
sync だけ df1678d で対応。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
「DSNと同じユーザー名 / パスワードを指定した場合」に引数を無視する、と書かれていますが、
実際の挙動は、「DSNにユーザー名 / パスワードが含まれている場合」に引数が無視されます。同じかどうかは全く関係ない挙動になります。