ext/bcmath: `BcMath\Number` class by SakiTakamachi · Pull Request #4187 · php/doc-en

SakiTakamachi · 2024-11-29T02:04:37Z

RFCs:
https://wiki.php.net/rfc/support_object_type_in_bcmath
https://wiki.php.net/rfc/fix_up_bcmath_number_class

stub:
https://github.com/php/php-src/blob/master/ext/bcmath/bcmath.stub.php

Girgias

Partial review as there is already a bunch that needs fixing across the board.

reference/bc/bcmath.number.xml

reference/bc/bcmath/number/construct.xml

reference/bc/bcmath/number/add.xml

reference/bc/bcmath/number/tostring.xml

reference/bc/bcmath/number/sub.xml

Co-authored-by: Gina Peter Banyard <girgias@php.net>

SakiTakamachi · 2024-12-02T04:08:31Z

@Girgias
Fixed!

SakiTakamachi · 2024-12-02T04:24:19Z

Hmm. I don't understand why CI turns red...
No problems occur in my local

edit:
I wanted to change the explanation a little, so I stopped including on the part where the error occurred.

Girgias

Some comments, the only concern is with the XIncludes, where I think waiting for @alfsb's PR to be merged might make more sense.

language-snippets.ent

reference/bc/bcmath.number.xml

Girgias · 2024-12-10T16:07:35Z

reference/bc/bcmath/number/compare.xml

+  </methodsynopsis>
+  <simpara>
+   Compare two arbitrary precision numbers.
+   This method behaves similar to the spaceship operator.


Add a link to it?

Added a link in 10b03c4

reference/bc/bcmath/number/div.xml

Girgias · 2024-12-10T16:11:05Z

reference/bc/bcmath/number/div.xml

+  </simpara>
+  <example>
+   <title>Example of <property>BcMath\Number::scale</property> of result object</title>
+   <programlisting role="php">


Move the example to the corresponding section, if you want to point it out in the return value you can add an xml:id and link tag

Moved in 57d7592

Girgias · 2024-12-10T16:13:35Z

reference/bc/bcmath/number/mod.xml

+  <!-- ValueError cases -->
+  <xi:include xpointer="xmlns(db=http://docbook.org/ns/docbook) xpointer(id('bcmath-number.add')/db:refsect1[@role='errors']/db:para[1])" />
+  <!-- The DivisionByZeroError case -->
+  <xi:include xpointer="xmlns(db=http://docbook.org/ns/docbook) xpointer(id('bcmath-number.div')/db:refsect1[@role='errors']/db:simpara[1])" />


It might be better to wait for php/doc-base#198 to be merged than using XIncludes with indices

It was merged a few days ago, and I think there are already published manuals under it. So it's probably safe to start using it now.

reference/bc/bcmath/number/pow.xml

reference/bc/bcmath/number/powmod.xml

Co-authored-by: Gina Peter Banyard <girgias@php.net>

reference/bc/bcmath/number/add.xml

reference/bc/bcmath/number/div.xml

SakiTakamachi · 2024-12-27T04:15:58Z

I thought I'd commented, but it seems I didn't....

I've fixed everything that needed to be fixed.

Girgias

I think the structural IDs and XInclude stuff can wait for a follow-up

created common part

32868b6

SakiTakamachi force-pushed the bcmath_number branch from a75b307 to f50378d Compare November 29, 2024 02:40

SakiTakamachi added 17 commits November 29, 2024 12:13

created class

78d52d4

edit book, ini

0d4e68e

Added the class into versions

824d901

Created construct, serialize, unserialize, toString

44f5092

Created add()

df9d597

Created sub()

5a711ab

Created div()

5a2b677

Created mul()

64e3458

Created mod()

3ee4949

Created pow()

34f4a6d

Created divmod()

e348369

Created powmod()

be8b29d

Created ceil()

8619f4c

Created floor()

de38dc7

Created round()

23ef913

Created compare()

67ad21f

Created sqrt()

3a9547b

SakiTakamachi force-pushed the bcmath_number branch from f50378d to 3a9547b Compare November 29, 2024 03:14

SakiTakamachi requested review from Girgias and ndossche November 29, 2024 04:06

Girgias requested changes Nov 29, 2024

View reviewed changes

SakiTakamachi and others added 7 commits December 2, 2024 12:08

address a comment

7b51ff8

Co-authored-by: Gina Peter Banyard <girgias@php.net>

address a comment

19d38dd

Co-authored-by: Gina Peter Banyard <girgias@php.net>

address a comment

88ca28e

Co-authored-by: Gina Peter Banyard <girgias@php.net>

address a comment

1917ae3

Co-authored-by: Gina Peter Banyard <girgias@php.net>

address a comment

646fe01

Co-authored-by: Gina Peter Banyard <girgias@php.net>

address a comment

228cba8

Co-authored-by: Gina Peter Banyard <girgias@php.net>

address a comment

3ffc207

Co-authored-by: Gina Peter Banyard <girgias@php.net>

Address comments and more

22792d5

SakiTakamachi added 2 commits December 2, 2024 13:13

changed "larger" to "greater" and "smaller than" to "less than"

10e1602

typo

cafb7ff

SakiTakamachi requested a review from Girgias December 2, 2024 04:16

SakiTakamachi added 3 commits December 2, 2024 13:47

Changed the scale param desctiption

3a7ed30

Deleted unnecessary descriptions

cd6f8d7

Avoid nesting includes

6899586

SakiTakamachi force-pushed the bcmath_number branch from c919793 to 6899586 Compare December 2, 2024 05:00

Girgias reviewed Dec 10, 2024

View reviewed changes

SakiTakamachi and others added 11 commits December 17, 2024 00:21

address a comment

c860c08

Co-authored-by: Gina Peter Banyard <girgias@php.net>

address a comment

043e7e2

Co-authored-by: Gina Peter Banyard <girgias@php.net>

address a comment

5b1228f

Co-authored-by: Gina Peter Banyard <girgias@php.net>

address a comment

d2e7031

Co-authored-by: Gina Peter Banyard <girgias@php.net>

address a comment

d480231

Co-authored-by: Gina Peter Banyard <girgias@php.net>

address a comment

cb0d697

Co-authored-by: Gina Peter Banyard <girgias@php.net>

address a comment

6a35375

Co-authored-by: Gina Peter Banyard <girgias@php.net>

Moved varlistentry of scale parameter to add()

60a76f1

Added a link to "spaceship operator"

10b03c4

fixed "+<literal>10" to "<literal>+10"

6411e68

Moded a example code

57d7592

alfsb reviewed Dec 16, 2024

View reviewed changes

reference/bc/bcmath/number/add.xml Show resolved Hide resolved

reference/bc/bcmath/number/div.xml Show resolved Hide resolved

Girgias approved these changes Jan 14, 2025

View reviewed changes

Girgias merged commit c7e83fb into php:master Jan 14, 2025
2 checks passed

SakiTakamachi mentioned this pull request Jan 29, 2025

ext/bcmath: Moved scale description from language-snippets to bcadd #4423

Merged

SakiTakamachi deleted the bcmath_number branch January 29, 2025 08:39

Conversation

SakiTakamachi commented Nov 29, 2024

Uh oh!

Girgias left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SakiTakamachi commented Dec 2, 2024

Uh oh!

SakiTakamachi commented Dec 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Girgias left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Girgias Dec 10, 2024

Choose a reason for hiding this comment

Uh oh!

SakiTakamachi Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Girgias Dec 10, 2024

Choose a reason for hiding this comment

Uh oh!

SakiTakamachi Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

Girgias Dec 10, 2024

Choose a reason for hiding this comment

Uh oh!

alfsb Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SakiTakamachi commented Dec 27, 2024

Uh oh!

Girgias left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SakiTakamachi commented Dec 2, 2024 •

edited

Loading