Only match exact main and subdomains#555
Merged
oscarotero merged 2 commits intophp-embed:masterfrom May 9, 2025
Merged
Conversation
|
+1 for this, it's biting us in production right now as our client's brand name ends in |
oscarotero
requested changes
May 9, 2025
oscarotero
approved these changes
May 9, 2025
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current host matching logic in ExtractorFactory checks if the host of the inputted url ends with the host of one of the adapters. That check is too broad though, it should only check exact matches and subdomain matches. Example: shop.weeztix.com urls are considered Twitter urls, because the host ends with x.com.