Added touchablility to scroll graph view -- Started with jz709u's code#82
Added touchablility to scroll graph view -- Started with jz709u's code#82mithunmathew1990 wants to merge 1 commit intophilackm:masterfrom
Conversation
|
Hi, thanks for working on this! I really appreciate it. It looks good and I definitely want to merge it in. I'll review it and merge it in once I've finished my exams in a few weeks, unfortunately I have no time until then. |
| var graphSizeExceedsWindow = false | ||
| if (self.viewportWidth < totalGraphWidth) { | ||
| graphSizeExceedsWindow = true | ||
| } |
There was a problem hiding this comment.
let graphSizeExceedsWindow = self.viewportWidth < totalGraphWidth is enough.
There was a problem hiding this comment.
Btw that part of the code (function setup ()) charges how the graph works when direction is set to left to right and number of items on the graph is less than screen size. Previously it was like a right aligned graph with this code it would be a graph that looks like leftToRight until screen is filled and then it work Would start looking like right aligned graph.
Please don't merge this function of it charges functionality of rightToLeft.
|
I've just refactored the code quite a lot and added in multiple plots & a few other features. We will have to go through this code and adapt it to the new version. Thanks a lot for the work @mithunmathew1990, @NunoAlexandre |
|
Hi @philackm, any update on this feature? |
|
Why this update (plot touchability) has been removed in latest pod? |
Hi,
I started with jz709u's code given in #69
-- Fixed crashes
-- Integrated code in examples to make it easy
-- Added code to show custom bar graph for selected bar
Changes
[implement PointSelectedProtocol and graphView.pointSelectedDelegate = viewController]
[just do a graphView.shouldCustomizeSelection = true]