Open
Conversation
phadej
requested changes
Jul 26, 2021
phadej
reviewed
Jul 26, 2021
phadej
reviewed
Jul 26, 2021
| start = Scanr1 $ \_ -> VNil | ||
|
|
||
| step :: forall m. N.SNatI m => Scanr1 m a -> Scanr1 ('S m) a | ||
| step (Scanr1 go) = Scanr1 $ \(x ::: xs) -> case N.snat :: N.SNat m of |
Owner
There was a problem hiding this comment.
This doesn't feel right. You shouldn't need to check length in the step case. I can take a look myself if you cannot find a way to avoid it.
Author
There was a problem hiding this comment.
In scanr1, the last element is special (it is the zero element), and so the 0 -> 1 step and the m -> m + 1 step (where m > 0) are different. But yeah please let me know if there's a better way to write this.
Author
There was a problem hiding this comment.
@phadej - let me know if you have any updates on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90