Open
Conversation
Author
|
@opoplawski are you on discord/slack/something? |
Contributor
|
othehunter on discord. |
opoplawski
requested changes
Jan 16, 2024
| @@ -0,0 +1,163 @@ | |||
| # -*- coding: utf-8 -*- | |||
|
|
|||
| # Copyright: (c) 2021, Chris Morton, cosmo@cosmo.2y.net | |||
Contributor
There was a problem hiding this comment.
You may want to update the year range here.
| @@ -0,0 +1,139 @@ | |||
| # -*- coding: utf-8 -*- | |||
|
|
|||
| # Copyright: (c) 2021, Chris Morton, cosmo@cosmo.2y.net | |||
| #!/usr/bin/python | ||
| # -*- coding: utf-8 -*- | ||
|
|
||
| # Copyright: (c) 2019, Frederic Bor <frederic.bor@wanadoo.fr> |
Contributor
There was a problem hiding this comment.
You probably want to add yourself here.
| DOCUMENTATION = """ | ||
| --- | ||
| module: pfsense_haproxy_frontend | ||
| version_added: "0.6.0" |
| DOCUMENTATION = """ | ||
| --- | ||
| module: pfsense_haproxy_frontend_server | ||
| version_added: "0.6.0" |
Comment on lines
+14
to
+16
| extaddr=dict(required=True, type='str'), | ||
| extaddr_port=dict(required=True, type='int'), | ||
| extaddr_ssl=dict(required=True, type='str'), |
Contributor
There was a problem hiding this comment.
You really don't want anything other name the id field to be required, otherwise you break removal with just the id. Use required_if with state present.
Comment on lines
+14
to
+15
| status=dict(required=True, type='str'), | ||
| desc=dict(required=True, type='str'), |
Contributor
There was a problem hiding this comment.
You really don't want anything other name the id field to be required, otherwise you break removal with just the id. Use required_if with state present.
Contributor
|
As an FYI - I'm doing a lot of work here: https://github.com/opoplawski/pfsensible-core/tree/module_base_extended to extend PFSenseModuleBase and write |
morey-tech
added a commit
to morey-tech/pfsensible-haproxy
that referenced
this pull request
Dec 16, 2025
Add complete Ansible module implementation for HAProxy frontends and frontend servers with corrected required field logic. Module Utils Changes: - Update copyright year to 2025 in haproxy_frontend.py - Update copyright year to 2025 in haproxy_frontend_server.py - Change required=True to required=False for non-primary-key fields (status, desc, extaddr, extaddr_port, extaddr_ssl) - Only primary identifiers remain required (name, frontend) New Ansible Modules: - Add pfsense_haproxy_frontend module for managing HAProxy frontends - Add pfsense_haproxy_frontend_server module for managing bind addresses - Set version_added to 0.2.0 for new release - Include comprehensive documentation and examples - Follow existing backend module patterns for consistency This allows deletion operations with minimal parameters (just state=absent plus identifier) and maintains consistency with the existing backend module architecture. Addresses feedback from: pfsensible#1
morey-tech
added a commit
to morey-tech/pfsensible-haproxy
that referenced
this pull request
Dec 17, 2025
Add complete Ansible module implementation for HAProxy frontends and frontend servers with corrected required field logic. Module Utils Changes: - Update copyright year to 2025 in haproxy_frontend.py - Update copyright year to 2025 in haproxy_frontend_server.py - Change required=True to required=False for non-primary-key fields (status, desc, extaddr, extaddr_port, extaddr_ssl) - Only primary identifiers remain required (name, frontend) New Ansible Modules: - Add pfsense_haproxy_frontend module for managing HAProxy frontends - Add pfsense_haproxy_frontend_server module for managing bind addresses - Set version_added to 0.2.0 for new release - Include comprehensive documentation and examples - Follow existing backend module patterns for consistency This allows deletion operations with minimal parameters (just state=absent plus identifier) and maintains consistency with the existing backend module architecture. Addresses feedback from: pfsensible#1
morey-tech
added a commit
to morey-tech/pfsensible-haproxy
that referenced
this pull request
Dec 17, 2025
Add complete Ansible module implementation for HAProxy frontends and frontend servers with corrected required field logic. Module Utils Changes: - Update copyright year to 2025 in haproxy_frontend.py - Update copyright year to 2025 in haproxy_frontend_server.py - Change required=True to required=False for non-primary-key fields (status, desc, extaddr, extaddr_port, extaddr_ssl) - Only primary identifiers remain required (name, frontend) New Ansible Modules: - Add pfsense_haproxy_frontend module for managing HAProxy frontends - Add pfsense_haproxy_frontend_server module for managing bind addresses - Set version_added to 0.2.0 for new release - Include comprehensive documentation and examples - Follow existing backend module patterns for consistency This allows deletion operations with minimal parameters (just state=absent plus identifier) and maintains consistency with the existing backend module architecture. Addresses feedback from: pfsensible#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
haproxy frontend changes.
may need updating if any of the base haproxy pfsense plugin has added new fields/etc.
looks like some of the comments/ still have references to the backend.
Will clean up.