feat: add virtual-ip module

[genofire]

solve #47

[irgama]

This feature would be quite useful. I am currently just copy-pasting the module into the collection I grab via ansible-galaxy.

For setting up a ipalias, for some reason I need to set both uniqid and subnet to the IP that I want. If I leave either blank I get an error.

[genofire]

Is your suggestion, to make this both parameter as required?

[irgama]

Oh, I was just making a note of the behaviour that I witnessed. I am not familiar enough with the module to know if both of them being set is required, or that is a bug. At the very least, if both must be set, that should be documented.

…

-Ian Robinson

On Fri, Aug 25, 2023, 11:40 AM genofire ***@***.***> wrote: Is your suggestion, to make this both parameter as required? — Reply to this email directly, view it on GitHub <#68 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACFM6H6H6A6IUZ3GVGVTM3TXXDBORANCNFSM6AAAAAAX2DZCW4> . You are receiving this because you commented.Message ID: ***@***.***>

[opoplawski]

Sorry for the delay in reviewing this. Could the review items and tests get fixed? Thanks.

[genofire]

Your runner/ci-pipeline is broken ....

[opoplawski]

Looks like the github ubuntu-latest image is broken. I've reverted to ubuntu-20.04. Please rebase on master.

[opoplawski]

I'm not sure this should be required - is it needed for the state = absent case?

[genofire]

Me too. Some code is not from me - ping @coffeelover

(And I do not touch that firewall part very often)

[coffeelover]

IIRC a mode is required or at least one mode should be default (i would prefer ipalias).
Also for state=absent, mode is required, because only for carp and ipalias the virtual interface has to be manually removed.

[opoplawski]

I would think we would need a "state", "present" entry.

[genofire]

Hmm, and an absent ?

[coffeelover]

It is needed for both states.

[opoplawski]

Is there no validation to be done?

[genofire]

We do not have some, should we delete that function (replace with pass) and hope that somebody else write some?

Or is it an blocker?

[Batman781]

Hi,
it seems that after my upgrade from 0.4.2 to 0.6.1 vip creation does not work anymore (the module name before was "pfsense virtualip" in your commit is "pfsense_virtual_ip")
Which version will contain this new commit?

[opoplawski]

I'm not aware of there ever being a pfsense_virtualip moduile in ansible-pfsense or pfsensible/core. But yeah, this should be called pfsense_virtualip. Hopefully @genofire will have some time to fix up the issues I raised. I'm not sure I have time to do it myself.

[opoplawski]

This still has a fair amount of cleanup to be done. Need to validate the integer inputs and need to check for vhid conflicts. I think it also should be able to generate the vhid if needed (and return it).