Focus on what not how#4
Open
akashchopra wants to merge 2 commits intopebblecode:masterfrom
akashchopra:master
Open
Focus on what not how#4akashchopra wants to merge 2 commits intopebblecode:masterfrom akashchopra:master
akashchopra wants to merge 2 commits intopebblecode:masterfrom
akashchopra:master
Conversation
Member
|
I think the general principles section frames the document well. The other additions are not controversial. Any other comments, or shall we merge this in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to focus on the what rather than the how, as discussed in Nathan's pull request. I agree with Tom that discussion of var does not belong in the doc, so I've omitted it.
I've added "composition over inheritance" as a "consider".
The comment on static types has been generalised to "avoid global state - examine all use of static types".
I've also added a bunch of other guidelines in an attempt to flesh things out.
Thoughts? Fire away!