fix(heimdall): display job properties in UI#43
Open
gauravwarale wants to merge 2 commits intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request restructures the job context data model by nesting the properties object inside a new parameters container within the job's context field, and updates the UI component to access properties through this new nested structure.
- Updated
JobTypetype definition to wrappropertiesinside a newparametersobject - Modified job details component to access context properties through the new nested path
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| web/src/modules/Jobs/Helper.tsx | Added parameters wrapper around existing properties object in JobType definition |
| web/src/modules/Jobs/JobDetails/JobDetailsHeader.tsx | Updated property access from context.properties to context.parameters.properties |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JoshMDiaz
approved these changes
Aug 20, 2025
wlggraham
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how job context properties are accessed and structured in the job-related components. The main change is introducing a new
parametersobject inside thecontextfield of theJobType, and updating all references to job context properties to use this new structure.Type and data structure updates:
JobTypetype definition inHelper.tsxto nestpropertiesinside a newparametersobject withincontext.Component logic updates:
JobDetailsHeader.tsxto referencejobData.context.parameters.propertiesinstead ofjobData.context.propertieswhen displaying job context properties.