Open
Conversation
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Table is mostly complete and partially functional.
A couple of notes:
Row based table = React component aligned table
Example:
Column base tables = purely presentational/Figma usage only
Why is the column based table mis-aligned?
Figma structure dictates that row are structured vertically, which is inconsistent with
htmlstructural requirements.The Figma Table component lacks
<Thead>and<Tbody>equivalent. Table source code won't include these, thus will be semantically invalid.Action items:
.figma.tsxfile to match newly added Figma elements.