feat(select): add dark mode support for <pf-select>#2952
feat(select): add dark mode support for <pf-select>#2952dali327519294 wants to merge 4 commits intopatternfly:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 70377f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @bennypowers 👋 |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Added basic Dark Mode support using @media (prefers-color-scheme: dark) and PatternFly global variables. The Goal: To ensure the component is future-proofed and ready to display correctly in dark themes when PatternFly officially implements Dark Mode across the ecosystem. Fixed bug 2681# |
|
@zeroedin has an approach in RedHat-UX/red-hat-design-system#2681. if we update PFE there to v4.2.0, we can hack around this in RHDS without having to introduce light/dark to PFE here. |
What I did
Fixed bug RedHat-UX/red-hat-design-system#2681
1.Added dark mode support for
<pf-select>to ensure proper contrast and accessibility in both light and dark themes.Testing Instructions
<pf-select>demo page.Notes to Reviewers