This repository was archived by the owner on Feb 5, 2025. It is now read-only.
fix(inline edit): remove clear element in internet explorer#1119
Open
mcoker wants to merge 1 commit intopatternfly:masterfrom
Open
fix(inline edit): remove clear element in internet explorer#1119mcoker wants to merge 1 commit intopatternfly:masterfrom
mcoker wants to merge 1 commit intopatternfly:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1076
Description
There are 2 "x" (clear) icons when editing a text input in IE/edge, because IE has a native pseudo element to clear an input.
Changes
Hiding the IE clear element and using the patternfly icon for consistency.
Link to rawgit and/or image
The build is failing for the tertiary navigation test below, which should have nothing to do with the inline edit pattern.
https://travis-ci.org/michael-coker/patternfly/builds/411338357
PR checklist (if relevant)