Composer Dependency Conflict: PHP 8 compatibility #176
Open
hkorik wants to merge 1 commit intopattern-lab:developfrom
Open
Composer Dependency Conflict: PHP 8 compatibility #176hkorik wants to merge 1 commit intopattern-lab:developfrom
hkorik wants to merge 1 commit intopattern-lab:developfrom
Conversation
santhosh-fernando
approved these changes
Oct 28, 2022
|
@santhosh-fernando @hkorik Thanks for your issue on this. I can confirm that this fixes one of two issues I was having while upgrading to PHP 8.1. This perhaps saves us from rewriting all of our components. (We had written them with the previous method of numbering filenames for ordering and this is deprecated on PatternLab Node.) Thanks from my team at Protiviti.com. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The composer package
doctrine/collectionsneeds to be allowed to upgrade to^1.6.5for php 8 compatibility.