Open
Conversation
Member
Author
|
I've got a commit on this branch that cleans up the config setting so diffs should make much more sense now. |
Member
Author
|
I could see using - self::$options["patternSourceDir"] =
- isset(self::$options["patternSourceDir"])
- ? self::$options["sourceDir"] . DIRECTORY_SEPARATOR . self::cleanDir(self::$options["patternSourceDir"])
- : self::$options["sourceDir"] . DIRECTORY_SEPARATOR . "_patterns";
+ self::$options["patternSourceDir"] =
+ self::getOption('paths.source.patterns')
+ ? self::$options["baseDir"] . self::cleanDir(self::getOption("paths.source.patterns"))
+ : self::$options["sourceDir"] . DIRECTORY_SEPARATOR . "_patterns";
|
Contributor
|
Oh wait a sec @EvanLovely are you just doing what I think you're doing here? Cleaning up the crappy whitespace with literally zero code changes otherwise? If so, can we merge this down to develop (yay clean diffs) so we can point any subsequent PRs at that easier to follow base? Or maybe a separate PR so this can act as an umbrella ticket? shrug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to fix #35 to bring in configurable paths besides just pointing towards source directory. This needs to be backwards compatible as well.