fix(twig engine): startup and running problems#1478
Merged
JosefBredereck merged 3 commits intodevfrom Feb 1, 2023
Merged
Conversation
mfranzke
added
bug 🐛
twig renderer
alexandar87
reviewed
Feb 1, 2023
alexandar87
left a comment
alexandar87
left a comment
There was a problem hiding this comment.
Actually, this is not passing the build after I run npm run start:
Pattern Engine twig / package @pattern-lab/engine-twig-php: Unexpected token ','
Contributor
Author
|
Thanks for your feedback. It only seems to be one piece of the solutions (solving the error before the one you're mentioning). |
mfranzke
changed the title
JosefBredereck
approved these changes
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1477
Summary of changes:
Added a missing entry (
package) to the schema of the twig renderer, which prevented to use a reworked config object (most likely a necessary followup to #1256, as this new field was introduced with this PR).