refactor: updated eslint devDepencencies#1306
Draft
mfranzke wants to merge 105 commits intopattern-lab:devfrom
Draft
refactor: updated eslint devDepencencies#1306mfranzke wants to merge 105 commits intopattern-lab:devfrom
mfranzke wants to merge 105 commits intopattern-lab:devfrom
Conversation
get upstream
get upstream
missed to replace mustache initially and incorrect handlebars two times (both in package name and URL)
This reverts commit 271dc8d.
This was referenced Mar 28, 2021
that are mentioned by the github pipeline as well
mfranzke
commented
Jan 26, 2022
| patternlab.config.paths.public.root | ||
| ) | ||
| ); | ||
| defaults.assets = [ |
Contributor
There was a problem hiding this comment.
I know this is an old PR which is still WIP, but could you elaborate why this gets removed when the PR only is about ESLint changes?
| return patternlab.server | ||
| .serve({ | ||
| cleanPublic: config.cleanPublic, | ||
| watch: true, |
Contributor
There was a problem hiding this comment.
Same goes for the removal of this line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
It's important that someone else with ESLint, babel and webpack knowledge would have a look at these changes, especially my three code comments and the necessary evaluations.
live-serverpackage to an external config fileadded
no-mixed-requires->node/no-mixed-requiresno-process-exit->node/no-process-exitupdated dependencies
eslint-plugin-importeslint-config-airbnb-baseWe're matching the ESLint version with the updates from this pull request and Prettier even already, as well as Node.
replaced
babel-eslintis now@babel/eslint-parser.", source https://www.npmjs.com/package/babel-eslint and https://babeljs.io/blog/2020/07/13/the-state-of-babel-eslintChanged
rulesESLint@7: https://eslint.org/docs/rules/#deprecated (seeaddedsection above as well)extendshttps://github.com/prettier/eslint-plugin-prettier#recommended-configuration:
and read further on the section
ESLint and babel configs
sub-packages ESLint config file with an extend to root isn't necessary, as ESLint would search for that config anyhow, but we need to reference the root
babel.config.jsin our monorepo, compare to e.g.https://babeljs.io/docs/en/config-files#root-babelconfigjson-file and https://babeljs.io/docs/en/config-files#file-relative-configuration
pending
Why do we have both a.eslintrc.jsand a.eslintrc.jsonin the root?#updatingdependenciesbitbybitbybitbybitbybitbybitbybitbybit