Token-like patterns no longer treated as templates#35
Open
mogsie wants to merge 1 commit intopattern-lab:masterfrom
Open
Token-like patterns no longer treated as templates#35mogsie wants to merge 1 commit intopattern-lab:masterfrom
mogsie wants to merge 1 commit intopattern-lab:masterfrom
Conversation
If you have templates that have typos in their includes, the use of the
Twig_Loader_String causes the typo to be echoed out:
{% include "foo" %}
results in the string "foo" to be printed out unless "foo" is a twig
template.
This change causes "foo" to no longer be printed out, but template
generation to fail, because "foo" is not present.
This change also allows more of the twig features to be used, such as
conditional includes and dynamic includes:
{% set foo = "something" %}
{% include [ foo, "fallback" ] %}
Before this change, the string "something" would always be printed.
After the change, either the template "something" is included,
otherwise, the template "fallback" is included, or else an error is
raised:
Twig_Error_Loader: Unable to find one of the following templates:
"something", "fallback"
Author
|
To be completely honest I expect this might break some pattern libraries, because of typos in obscure twig files. So it might be that this behaviour should be "opt-in". I wanted to do that, but I was unsure of the best way of providing this opt-in-ness, or if it is a good idea at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have templates that have typos in their includes, the use of the
Twig_Loader_String causes the typo to be echoed out:
results in the string "foo" to be printed out unless "foo" is a twig
template.
This change causes "foo" to no longer be printed out, but template
generation to fail, because "foo" is not present.
This change also allows more of the twig features to be used, such as
conditional includes and dynamic includes:
Before this change, the string "something" would always be printed.
After the change, either the template "something" is included,
otherwise, the template "fallback" is included, or else an error is
raised: