This repository was archived by the owner on Apr 22, 2021. It is now read-only.
Modified model's static all() method to use the create() method.#48
Open
stephenr85 wants to merge 1 commit intopathable:masterfrom
Open
Modified model's static all() method to use the create() method.#48stephenr85 wants to merge 1 commit intopathable:masterfrom
stephenr85 wants to merge 1 commit intopathable:masterfrom
Conversation
In instances where we want to inject models into a page from the server, it makes sense to use Model.all().add([...]), but the model instances were not being registered because they were using the default Backbone.Collection. I have modified it to use a pre-attached Model.Collection class (allowing extra customization/configuration), or automatically extending the Backbone.Collection's model() method to use Model.create().
Contributor
|
Hi @stephenr85! Models are added to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In instances where we want to inject models into a page from the server, it makes sense to use Model.all().add([...]), but the model instances were not being registered because they were using the default Backbone.Collection.
I have modified it to use a pre-attached Model.Collection class (allowing extra customization/configuration), or automatically extending the Backbone.Collection's model() method to use Model.create().