Add conceal to double and tripple equal#1155
Open
nicanordlc wants to merge 1 commit intopangloss:masterfrom
Open
Add conceal to double and tripple equal#1155nicanordlc wants to merge 1 commit intopangloss:masterfrom
nicanordlc wants to merge 1 commit intopangloss:masterfrom
Conversation
* Add changes to `README.md`
700739a to
c97a1a3
Compare
Author
|
@amadeus I think this is ready to check. ( : Can you check this up, or can you tell me who else can approve/check this ? 👋 |
amadeus
reviewed
Nov 11, 2019
|
|
||
| syntax cluster jsExpression contains=jsBracket,jsParen,jsObject,jsTernaryIf,jsTaggedTemplate,jsTemplateString,jsString,jsRegexpString,jsNumber,jsFloat,jsOperator,jsOperatorKeyword,jsBooleanTrue,jsBooleanFalse,jsNull,jsFunction,jsArrowFunction,jsGlobalObjects,jsExceptions,jsFutureKeys,jsDomErrNo,jsDomNodeConsts,jsHtmlEvents,jsFuncCall,jsUndefined,jsNan,jsPrototype,jsBuiltins,jsNoise,jsClassDefinition,jsArrowFunction,jsArrowFuncArgs,jsParensError,jsComment,jsArguments,jsThis,jsSuper,jsDo,jsForAwait,jsAsyncKeyword,jsStatement,jsDot | ||
| syntax cluster jsAll contains=@jsExpression,jsStorageClass,jsConditional,jsRepeat,jsReturn,jsException,jsTry,jsNoise,jsBlockLabel | ||
| syntax cluster jsAll contains=@jsExpression,jsStorageClass,jsConditional,jsRepeat,jsReturn,jsException,jsTry,jsNoise,jsBlockLabel,jsDoubleEqual,jsTripleEqual |
Collaborator
There was a problem hiding this comment.
These should actually be added to jsExpression above, not all
|
README.md update also please 🙏 |
|
any movement on this PR? |
nicanordlc
commented
Sep 2, 2021
Comment on lines
-71
to
+84
| let g:javascript_conceal_function = "ƒ" | ||
| let g:javascript_conceal_null = "ø" | ||
| let g:javascript_conceal_this = "@" | ||
| let g:javascript_conceal_return = "⇚" | ||
| let g:javascript_conceal_undefined = "¿" | ||
| let g:javascript_conceal_NaN = "ℕ" | ||
| let g:javascript_conceal_prototype = "¶" | ||
| let g:javascript_conceal_static = "•" | ||
| let g:javascript_conceal_super = "Ω" | ||
| let g:javascript_conceal_arrow_function = "⇒" | ||
| let g:javascript_conceal_noarg_arrow_function = "🞅" | ||
| let g:javascript_conceal_function = "ƒ" | ||
| let g:javascript_conceal_null = "ø" | ||
| let g:javascript_conceal_this = "@" | ||
| let g:javascript_conceal_return = "⇚" | ||
| let g:javascript_conceal_undefined = "¿" | ||
| let g:javascript_conceal_NaN = "ℕ" | ||
| let g:javascript_conceal_prototype = "¶" | ||
| let g:javascript_conceal_static = "•" | ||
| let g:javascript_conceal_super = "Ω" | ||
| let g:javascript_conceal_arrow_function = "⇒" | ||
| let g:javascript_conceal_noarg_arrow_function = "🞅" | ||
| let g:javascript_conceal_underscore_arrow_function = "🞅" | ||
| let g:javascript_conceal_double_equal = "≈" | ||
| let g:javascript_conceal_triple_equal = "≡" |
Author
There was a problem hiding this comment.
Hi @bradwood , which part of the README.md needs to be updated ?
Collaborator
|
Also there was some changes I requested that would need to happen before this can get merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1154
Example code
Not the best code example I guess but here you go... 😅
With
concealAnyone feel free to point my 🚢 to the right direction 😬