Make qemu debug port output configurable#552
Make qemu debug port output configurable#552pfmooney wants to merge 1 commit intooxidecomputer:masterfrom
Conversation
|
I think we might've discussed this offline, but I forget where we landed on the idea: what about using the Propolis logger as a sink for these messages (possibly sticking an extra key/value pair on them for easy filtering)? That would not only avoid having |
|
Doing that would imply adding line-buffering to the debug port output, lest it turn every byte of log output into a line of slog output. Even with that, I'm not sure how we would appreciate having to filter those out when looking at the propolis logs. I've been working on various bits to cut down on the background noise which we emit in those logs (unhandled MSRs/registers/etc) |
gjcolombo
left a comment
There was a problem hiding this comment.
I did line buffering for PHD long enough ago that I forgot it's a freestanding problem we'd have to solve 😅
This LGTM, let's go ahead and merge.
The default of dumping
debug.outfiles everywhere that propolis-standalone is run is a bit unnecessary if that output isn't desired.