reuse code to read files, and let autodetect where look for#21
Open
masterzorag wants to merge 2 commits intoorbisdev:masterfrom
Open
reuse code to read files, and let autodetect where look for#21masterzorag wants to merge 2 commits intoorbisdev:masterfrom
masterzorag wants to merge 2 commits intoorbisdev:masterfrom
Conversation
add standard facility to open file, alloc, read and close if path start with "host0:" file will be readed via ps4link if not, from local via open/read/close this can be reused anytime we have to read a file in memory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as seen in #20, we should avoid duplicating existing code
check commitlog
this one will autodetect if looking via host0 or local just by looking at path, so we can just copy file in mem, then use it as .mod/.png etc with a little wrapper
also, we can now switch orbis2dLoadPngFromHost_v2 to more generic orbis2dLoadPngFromFile, and remove last added orbis2dLoadPngFromSandbox now useless
does not break existing code, so rebuild/update in order:
libps4link, libmod, liborbis2d, samples