Skip to content

Conversation

@elfkuzco
Copy link

Rationale

This PR adds an endpoint to retrieve a download/view URLs for zims

Changes

  • add download_base_url and view_base_url to collection model
  • add function to query db for zims and compute their download/view urls

This closes #137

@elfkuzco elfkuzco self-assigned this Feb 12, 2026
@elfkuzco elfkuzco linked an issue Feb 12, 2026 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.51%. Comparing base (65335f9) to head (ee0e2f3).
⚠️ Report is 3 commits behind head on cms-upgrade.

Files with missing lines Patch % Lines
backend/src/cms_backend/db/books.py 88.88% 0 Missing and 2 partials ⚠️
backend/src/cms_backend/api/routes/books.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           cms-upgrade     #154      +/-   ##
===============================================
+ Coverage        80.31%   80.51%   +0.20%     
===============================================
  Files               43       44       +1     
  Lines             1702     1735      +33     
  Branches           149      153       +4     
===============================================
+ Hits              1367     1397      +30     
- Misses             291      292       +1     
- Partials            44       46       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elfkuzco elfkuzco requested a review from benoit74 February 12, 2026 10:02
Copy link
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API to retrieve ZIM view + download URLs

2 participants