-
Notifications
You must be signed in to change notification settings - Fork 2
fix(docs): DSPX-2409 replace SDK README code example with working code #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Mary Dickson <mary.dickson@virtru.com>
Summary of ChangesHello @marythought, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the README.md by replacing an outdated code example with a complete, working one, and adding valuable context like configuration details and prerequisites. The introduction of READMETest.java to validate the README's code examples is an excellent addition that will help keep the documentation synchronized with the code. I have a couple of minor suggestions for the new test file to improve its robustness and adherence to best practices.
Signed-off-by: Mary Dickson <mary.dickson@virtru.com>
X-Test Failure Report |
|



Fixed API References
import io.opentdf.platform.sdk.Reader;(non-existent class)import io.opentdf.platform.sdk.TDF;Reader reader = ...→TDF.Reader reader = ...(Reader is a nested class within TDF)Complete Working Example
FileChannel(required forSeekableByteChannel)throws ExceptionQuickstart Alignment
Replaced generic placeholders with actual quickstart values:
platformEndpoint:localhost:8080(washttps://your.cluster/)clientId:opentdf(wasmyClient)clientSecret:secret(wastoken)kasUrl:http://localhost:8080/kas(new)dataAttribute:https://opentdf.io/attr/department/value/finance(wasattr1,attr2)Documentation Enhancements
Added Configuration Documentation
Configuration Values table with defaults and descriptions
Prerequisites section with setup instructions:
departmentattributeExpected Output section:
TDF created successfully
Successfully created and decrypted TDF
Note that
output.txtcontains the decrypted plaintext:Hello, world!Automated Testing
Created
READMETest.javathat validates code blocks:Readerimport not usedTDF.Readerused correctly instead of standaloneReadersdk.loadTDF,sdk.createTDF)Prevents future API changes from breaking README examples.