Skip to content

OCPQE-31553:adjust qe sa and permission test cases per new change#631

Open
kuiwang02 wants to merge 1 commit intoopenshift:mainfrom
kuiwang02:preflight
Open

OCPQE-31553:adjust qe sa and permission test cases per new change#631
kuiwang02 wants to merge 1 commit intoopenshift:mainfrom
kuiwang02:preflight

Conversation

@kuiwang02
Copy link
Contributor

/cc @jianzhangbjz @Xia-Zhao-rh @bandrade

Summary

This PR adjusts OLM v1 qe SA and preflight permission test cases per new change from boxcutterruntime, ensuring compatibility across all 4 environment combinations.

Besides them, it also enhance Makefile for make verify to report error and change fmt target from auto-fix to report error and provide how to fix. Or else, if the case owner forget to make correct format, tests-extension will not report error and pass the job. For example olmv1-singleownnamespace.go has format error and the tests-extension job of the PR which submit the code does not report error, but actualy the code is not good format. here, we enhance Makefile and correct it.

Environment Coverage

Env Preflight Boxcutter Status
Env1 ✅ Tested
Env2 ✅ Tested
Env3 ✅ Tested
Env4 ✅ Tested

assisted-by: Claude Code

@openshift-ci openshift-ci bot requested a review from bandrade February 5, 2026 05:49
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 5, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2026

@kuiwang02: This pull request references OCPQE-31553 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

/cc @jianzhangbjz @Xia-Zhao-rh @bandrade

Summary

This PR adjusts OLM v1 qe SA and preflight permission test cases per new change from boxcutterruntime, ensuring compatibility across all 4 environment combinations.

Besides them, it also enhance Makefile for make verify to report error and change fmt target from auto-fix to report error and provide how to fix. Or else, if the case owner forget to make correct format, tests-extension will not report error and pass the job. For example olmv1-singleownnamespace.go has format error and the tests-extension job of the PR which submit the code does not report error, but actualy the code is not good format. here, we enhance Makefile and correct it.

Environment Coverage

Env Preflight Boxcutter Status
Env1 ✅ Tested
Env2 ✅ Tested
Env3 ✅ Tested
Env4 ✅ Tested

assisted-by: Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kuiwang02
Once this PR has been reviewed and has the lgtm label, please assign perdasilva for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kuiwang02
Copy link
Contributor Author

it is better to wait PR cluster-olm repo 163 to be merged and go into payload together.

@kuiwang02
Copy link
Contributor Author

/payload-job periodic-ci-openshift-operator-framework-operator-controller-release-4.22-periodics-e2e-aws-ovn-upi-extended-f2

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 5, 2026

@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-operator-framework-operator-controller-release-4.22-periodics-e2e-aws-ovn-upi-extended-f2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0099f4a0-0268-11f1-9cbe-1d1d9e4a5ae8-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants